-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: remove extra parameter in accelerator registry decorator #20974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
YgLK
wants to merge
426
commits into
Lightning-AI:main
from
YgLK:bugfix/accelerator-registry-decorator
Closed
fix: remove extra parameter in accelerator registry decorator #20974
YgLK
wants to merge
426
commits into
Lightning-AI:main
from
YgLK:bugfix/accelerator-registry-decorator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jirka Borovec <[email protected]>
update tutorials to `b83fde09` Co-authored-by: Borda <[email protected]>
* bump: Torch `2.5.0` * push docker * docker * 2.5.1 and mypy * update USE_DISTRIBUTED=0 test * also for pytorch lightning no distributed * set USE_LIBUV=0 on windows * try drop pickle warning * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * disable compiling update_metrics * bump 2.2.x to bugfix * disable also log in logger connector (also calls metric) * more point release bumps * remove unloved type ignore and print some more on exit * update checkgroup * minor versions * shortened version in build-pl * pytorch 2.4 is with python 3.11 * 2.1 and 2.3 without patch release * for 2.4.1: docker with 3.11 test with 3.12 --------- Co-authored-by: Thomas Viehmann <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ers (Lightning-AI#20379) * Fix checkpoint progress for fit loop and batch loop * Check loss parity * Rename test * Fix validation loop handling on restart * Fix loop reset test * Avoid skipping to val end if saved mid validation * Fix type checks in compare state dicts * Fix edge cases and start from last with and without val * Clean up * Formatting * Avoid running validation when restarting from last * Fix type annotations * Fix formatting * Ensure int max_batch * Fix condition on batches that stepped * Remove expected on_train_epoch_start when restarting mid epoch
* fix batchsampler does not work correctly * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add batch sampler shuffle state test
…ightning-AI#20372) Co-authored-by: Luca Antiga <[email protected]>
update CI Co-authored-by: Thomas Viehmann <[email protected]>
…Lightning-AI#20399) Co-authored-by: Alan Chu <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Alan Chu <[email protected]>
…#20403) * Allow callbacks to be restored not just during training * add test case * test test case failure * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test case --------- Co-authored-by: Alan Chu <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <[email protected]>
…ning-AI#20444) Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.11.8 to 0.11.9. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.11.8...v0.11.9) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bump python 3.9+ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * --unsafe-fixes * contextlib.AbstractContextManager * type: ignore[misc] * update CI * apply fixes * apply fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <[email protected]>
…py for `torch-xla>=2.5` (Lightning-AI#20442) * Replace `using_pjrt()` xla runtime `device_type()` check with in xla.py Fixes Lightning-AI#20419 `torch_xla.runtime.using_pjrt()` is removed in pytorch/xla#7787 This PR replaces references to that function with a check to [`device_type()`](https://github.com/pytorch/xla/blob/master/torch_xla/runtime.py#L83) to recreate the behavior of that function, minus the manual initialization * Added tests/refactored for version compat * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * precommit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
feat(cli): after_instantiate_classes hook Co-authored-by: Luca Antiga <[email protected]>
…on()` to robustly seed NumPy-dependent dataloader workers (Lightning-AI#20369) * Update seed.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update seed.py * Update seed.py * Update seed.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Luca Antiga <[email protected]>
…Lightning-AI#20440) * Minimal transformer examples * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add tests for compile after fsdp2/tp * Add README's * Add docs * Rename folder, add cross-reference * Fix link * Newline after code-block directive * Update section name * Fix reference * Half standalone tests batch size * Fix integration tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ng-AI#20320) * Update fabric.py * Update deepspeed.py * Update fsdp.py * Update strategy.py * Update xla_fsdp.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]>
* Fix compatibility for bitsandbytes>=0.46 * --upgrade-strategy=eager --------- Co-authored-by: Jirka B <[email protected]>
…") (Lightning-AI#20959) Fix typo in glossary
* ci: debug sorting group-check * trigger * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * @bump/node20 * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * Empty-Commit * dependabot/npm_and_yarn/multi-63fbbd1def * dependabot/npm_and_yarn/brace-expansion-1.1.12 * dependabot/npm_and_yarn/octokit/webhooks-9.26.3 * dependabot/npm_and_yarn/braces-3.0.3 * dependabot/npm_and_yarn/multi-4e11cecdf1 * dependabot/npm_and_yarn/json5-1.0.2 * dependabot/npm_and_yarn/multi-3e154a7e10 * bump/5.5 * Apply suggestions from code review
…0.0,<1.42.0 in /requirements (Lightning-AI#20965) build(deps): update awscli requirement in /requirements Updates the requirements on [awscli](https://github.com/aws/aws-cli) to permit the latest version. - [Release notes](https://github.com/aws/aws-cli/releases) - [Commits](aws/aws-cli@1.30.0...1.41.3) --- updated-dependencies: - dependency-name: awscli dependency-version: 1.41.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tning-AI#20966) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.9.1 to 7.9.2. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](coveragepy/coveragepy@7.9.1...7.9.2) --- updated-dependencies: - dependency-name: coverage dependency-version: 7.9.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…with FSDP strategy (Lightning-AI#20964) * Add test for FSDP with CUDAAccelerator instance * update error message * update the test --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ntation (Lightning-AI#20931) * default behavior * clarify some docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20974.org.readthedocs.build/en/20974/